Attention is currently required from: Lean Sheng Tan, Mario Scheithauer.
Paul Menzel has posted comments on this change by Mario Scheithauer. ( https://review.coreboot.org/c/coreboot/+/84399?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/ehl/fsp_params: Fix double setting of 'PchPwrOptEnable' ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84399/comment/28e63eae_306985bd?usp... : PS3, Line 7: Fix double setting of 'PchPwrOptEnable' I misunderstood the summary. Maybe something like:
Do not re-enable PchPwrOptEnable for real-time tuning
https://review.coreboot.org/c/coreboot/+/84399/comment/94e85fa1_2014b9bf?usp... : PS3, Line 9: If real-time tuning was enabled, 'PchPwrOptEnable' was set two times. … with different values.