Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49614 )
Change subject: soc/intel/common/block/dmi: add a function to check DMI SRL status
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/dmi/dmi.c:
https://review.coreboot.org/c/coreboot/+/49614/comment/2a5f923b_8a0f35f4
PS7, Line 23: locked = pcr_read32(PID_DMI, PCR_DMI_DMICTL) & PCR_DMI_DMICTL_SRLOCK;
This seems backwards; if PDMI, use DMICTL? But the comment for MPC says […]
right, it's the other way round: MPC.SRL for PDMI (PCH-H) and DMICTL.SRL for OPDMI (PCH-LP, PCH-N)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91d689218855bd1fb307aaf6080ddf6e8e046bce
Gerrit-Change-Number: 49614
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 24 Jan 2021 12:01:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment