Change in coreboot[master]: mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45775 )
Change subject: mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder ......................................................................
mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder
We store the rmainder in Local0, but we never use it.
Change-Id: I4d209d7434508cb626aca8e7df50cc1c424e294a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/packardbell/ms2290/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45775/1
diff --git a/src/mainboard/packardbell/ms2290/acpi/battery.asl b/src/mainboard/packardbell/ms2290/acpi/battery.asl index 2f46f57..448cb72 100644 --- a/src/mainboard/packardbell/ms2290/acpi/battery.asl +++ b/src/mainboard/packardbell/ms2290/acpi/battery.asl @@ -53,7 +53,7 @@ Store(Local2, Index(Arg0, 2)) // Last full charge capacity Store(1, PAGE) Store(BADV, Index(Arg0, 4)) // Design Voltage - Divide (Local2, 20, Local0, Index(Arg0, 5)) // Warning capacity + Divide (Local2, 20, , Index(Arg0, 5)) // Warning capacity
Store(1, PAGE) Store (BASN, Local0)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45775 )
Change subject: mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45775 )
Change subject: mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45775/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45775/1//COMMIT_MSG@9 PS1, Line 9: rmainder remainder
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45775
to look at the new patch set (#2).
Change subject: mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder ......................................................................
mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder
We store the remainder in Local0, but we never use it.
Change-Id: I4d209d7434508cb626aca8e7df50cc1c424e294a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/packardbell/ms2290/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45775/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45775 )
Change subject: mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45775/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45775/1//COMMIT_MSG@9 PS1, Line 9: rmainder
remainder
Thx
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45775 )
Change subject: mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder ......................................................................
mb/packardbell/ms2290/acpi/battery.asl: Remove unused remainder
We store the remainder in Local0, but we never use it.
Change-Id: I4d209d7434508cb626aca8e7df50cc1c424e294a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45775 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/packardbell/ms2290/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/packardbell/ms2290/acpi/battery.asl b/src/mainboard/packardbell/ms2290/acpi/battery.asl index 2f46f57..448cb72 100644 --- a/src/mainboard/packardbell/ms2290/acpi/battery.asl +++ b/src/mainboard/packardbell/ms2290/acpi/battery.asl @@ -53,7 +53,7 @@ Store(Local2, Index(Arg0, 2)) // Last full charge capacity Store(1, PAGE) Store(BADV, Index(Arg0, 4)) // Design Voltage - Divide (Local2, 20, Local0, Index(Arg0, 5)) // Warning capacity + Divide (Local2, 20, , Index(Arg0, 5)) // Warning capacity
Store(1, PAGE) Store (BASN, Local0)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)