Attention is currently required from: Francois Toguo Fotso, Martin Roth, Nikunj Dadhania, Patrick Rudolph. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49258 )
Change subject: This change implements CrashLog for intel TGL. ......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49258/comment/ca990207_1c3efd8c PS5, Line 9: Intel based platforms It is not supported on all Intel platform, please make more specific.
https://review.coreboot.org/c/coreboot/+/49258/comment/646c5744_73afe11a PS5, Line 14: Built, crashLog data generated, extracted, processed, decoded sucessfully. Test had been done which platform need to mentioned, is that Tigerlake RVP platform?
Patchset:
PS5: At least please separated the commit into ACPI BERT table related,and how TGL implement the feature
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/49258/comment/9b8a5ae0_86fc47ee PS5, Line 1557: current += bert->header.length; We may need a current = acpi_align_current(current); after Current had been updated.
File src/include/cper.h:
https://review.coreboot.org/c/coreboot/+/49258/comment/fbeb1991_887a8b1f PS5, Line 384: __packed Packed needed here?
-
Lance Zhao (Code Review)