Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62805 )
Change subject: mb/google: Remove unused cpu device ......................................................................
mb/google: Remove unused cpu device
The cpu device listed in MediaTek platforms' devicetree.cb doesn't actually do anything, except causing an error during device initialization:
CPU: 00 missing read_resources
Therefore, remove it from the devicetree.
BUG=b:224419346 TEST=emerge-corsola coreboot TEST=Krabby booted up successfully BRANCH=none
Change-Id: Ibf9f7cf65da6a0dd0a0e1f556d5772573ba3e930 Signed-off-by: Yu-Ping Wu yupingso@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/62805 Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Rex-BC Chen rex-bc.chen@mediatek.com Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/asurada/devicetree.cb M src/mainboard/google/cherry/devicetree.cb M src/mainboard/google/corsola/devicetree.cb M src/mainboard/google/kukui/devicetree.cb M src/mainboard/google/oak/devicetree.cb 5 files changed, 5 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Hung-Te Lin: Looks good to me, approved Rex-BC Chen: Looks good to me, approved
diff --git a/src/mainboard/google/asurada/devicetree.cb b/src/mainboard/google/asurada/devicetree.cb index 0bdeec2..91ff9ce 100644 --- a/src/mainboard/google/asurada/devicetree.cb +++ b/src/mainboard/google/asurada/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only
chip soc/mediatek/mt8192 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end diff --git a/src/mainboard/google/cherry/devicetree.cb b/src/mainboard/google/cherry/devicetree.cb index 17fccc2..c16350c 100644 --- a/src/mainboard/google/cherry/devicetree.cb +++ b/src/mainboard/google/cherry/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only
chip soc/mediatek/mt8195 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end diff --git a/src/mainboard/google/corsola/devicetree.cb b/src/mainboard/google/corsola/devicetree.cb index 0c4bcb5..0e8bb91 100644 --- a/src/mainboard/google/corsola/devicetree.cb +++ b/src/mainboard/google/corsola/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only
chip soc/mediatek/mt8186 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end diff --git a/src/mainboard/google/kukui/devicetree.cb b/src/mainboard/google/kukui/devicetree.cb index 8efab95..45f2aad 100644 --- a/src/mainboard/google/kukui/devicetree.cb +++ b/src/mainboard/google/kukui/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only
chip soc/mediatek/mt8183 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end diff --git a/src/mainboard/google/oak/devicetree.cb b/src/mainboard/google/oak/devicetree.cb index f021ab2..c11a901 100644 --- a/src/mainboard/google/oak/devicetree.cb +++ b/src/mainboard/google/oak/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only
chip soc/mediatek/mt8173 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end
-
Julius Werner (Code Review)