build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ......................................................................
Patch Set 65:
(14 comments)
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/romstage.c:
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 20: FSP_M_CONFIG *mem_cfg; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 23: struct spd_block blk = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 24: .addr_map = { 0x50, 0x51, 0x52, 0x53, }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 24: .addr_map = { 0x50, 0x51, 0x52, 0x53, }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 25: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 27: mem_cfg->DqPinsInterleaved = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 28: get_spd_smbus(&blk); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 29: mem_cfg->MemorySpdDataLen = blk.len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 30: mem_cfg->MemorySpdPtr00 = (uintptr_t)blk.spd_array[0]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 31: mem_cfg->MemorySpdPtr10 = (uintptr_t)blk.spd_array[2]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 32: mem_cfg->MemorySpdPtr01 = (uintptr_t)blk.spd_array[1]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 33: mem_cfg->MemorySpdPtr11 = (uintptr_t)blk.spd_array[3]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 34: mem_cfg->UserBd = BOARD_TYPE_SERVER; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/32734/65/src/mainboard/supermicro/x... PS65, Line 36: mupd->FspmTestConfig.DmiVc1 = 1; please, no spaces at the start of a line