Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Jakub Czapiga, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84039?usp=email )
Change subject: cbmem.h: Change return type of cbmem_get_region
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84039/comment/df136086_954a6f99?usp... :
PS6, Line 13: checked for NULL later.
So it realized thanks to LTO that we didn't consistently initialize
variables, is that right? That would make this change actually fix
something and worth to mention.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84039?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib3e09a75380faf9f533601368993261f042422ef
Gerrit-Change-Number: 84039
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 23 Aug 2024 11:51:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes