Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36374 )
Change subject: soc/skylake/vr_config: print mch_id in hex ......................................................................
soc/skylake/vr_config: print mch_id in hex
Change-Id: I89e2bccf3fb99b20dde38745fc124d5dc95feb78 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/soc/intel/skylake/vr_config.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/36374/1
diff --git a/src/soc/intel/skylake/vr_config.c b/src/soc/intel/skylake/vr_config.c index 2be9c71..da2bfc8 100644 --- a/src/soc/intel/skylake/vr_config.c +++ b/src/soc/intel/skylake/vr_config.c @@ -227,7 +227,7 @@ return icc_max[domain]; } default: - printk(BIOS_ERR, "ERROR: Unknown MCH (%u) in VR-config\n", mch_id); + printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config\n", mch_id); } return 0; } @@ -297,7 +297,7 @@ return loadline[domain]; } default: - printk(BIOS_ERR, "ERROR: Unknown MCH (%u) in VR-config\n", mch_id); + printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config\n", mch_id); } return 0; }
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36374 )
Change subject: soc/skylake/vr_config: print mch_id in hex ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36374 )
Change subject: soc/skylake/vr_config: print mch_id in hex ......................................................................
soc/skylake/vr_config: print mch_id in hex
Change-Id: I89e2bccf3fb99b20dde38745fc124d5dc95feb78 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36374 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/intel/skylake/vr_config.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/soc/intel/skylake/vr_config.c b/src/soc/intel/skylake/vr_config.c index 2be9c71..da2bfc8 100644 --- a/src/soc/intel/skylake/vr_config.c +++ b/src/soc/intel/skylake/vr_config.c @@ -227,7 +227,7 @@ return icc_max[domain]; } default: - printk(BIOS_ERR, "ERROR: Unknown MCH (%u) in VR-config\n", mch_id); + printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config\n", mch_id); } return 0; } @@ -297,7 +297,7 @@ return loadline[domain]; } default: - printk(BIOS_ERR, "ERROR: Unknown MCH (%u) in VR-config\n", mch_id); + printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config\n", mch_id); } return 0; }