Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42462 )
Change subject: soc/intel/jasperlake: set SerialIoUartDebugMode to skip Uart Init
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42462/4/src/soc/intel/jasperlake/ro...
File src/soc/intel/jasperlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42462/4/src/soc/intel/jasperlake/ro...
PS4, Line 84: SerialIoUartDebugMode
This is the new addition Karthik. […]
Ok, makes sense. If that is the case, can you just assign the devicetree config here
i.e. m_cfg->SerialIoUartDebugMode = config->SerialIoUartMode[CONFIG_UART_FOR_CONSOLE];
This will help to avoid the configuration from digressing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fda2ace3b1f63159e9809d6a3044a3bad452f07
Gerrit-Change-Number: 42462
Gerrit-PatchSet: 5
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamirbohra@gmail.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 16:13:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment