Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39638 )
Change subject: drivers/intel/gma: hook up GMA for Skylake+ ......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39638/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39638/12//COMMIT_MSG@11 PS12, Line 11: TEST=Used GMA functionality (brightness) on a Skylake laptop
Done
Fixed as of CB:39883 and CB:39731.
https://review.coreboot.org/c/coreboot/+/39638/20/src/mainboard/intel/kunimi... File src/mainboard/intel/kunimitsu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39638/20/src/mainboard/intel/kunimi... PS20, Line 3: # Set backlight PWM value for eDP : register "gpu_pch_backlight_pwm_hz" = "200" # PWM frequency : : # Enable Panel as eDP and configure power delays : register "gpu_pp_up_delay_ms" = "200" # T3 : register "gpu_pp_backlight_on_delay_ms" = "1" # T7 : register "gpu_pp_backlight_off_delay_ms" = "200" # T9 : register "gpu_pp_down_delay_ms" = "50" # T10 : register "gpu_pp_cycle_delay_ms" = "500" # T12
they're necessary for libgfxinit, but not for ACPI backlight control
Because FSP GOP and VGABIOS can do it otherwise. Right.
Probably should be added to the Razer board then, but not here.
-
Benjamin Doron (Code Review)