Attention is currently required from: Michał Żygowski, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michal Motyl, Werner Zeh, Patrick Rudolph, Piotr Król, HAOUAS Elyes.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50594 )
Change subject: src: use ARRAY_SIZE where possible
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/50594/comment/e4848f2a_b0cf23d9
PS2, Line 3773: ARRAY_SIZE(useful_addresses); addr++)
The whole file is a mess. I'd rather fix the coding style in a follow-up. […]
There are a few more instances of this now, but I'm not too concerned due to https://review.coreboot.org/q/topic:%22clang-format-all-the-things%22+(statu...)
(This issue came to my attention during work on that topic)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I083704fd48faeb6c67bba3367fbcfe554a9f7c66
Gerrit-Change-Number: 50594
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 15 Feb 2021 10:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment