Attention is currently required from: Lance Zhao, Jason Glenesk, Raul Rangel, Matt DeVillier, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, Fred Reitberger, Tim Chu, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74601 )
Change subject: ACPI: Make FADT entries for RTC/CMOS architectural
......................................................................
Patch Set 2:
(2 comments)
File src/arch/x86/acpi.c:
https://review.coreboot.org/c/coreboot/+/74601/comment/643267b0_6ec2e277
PS1, Line 32: #define RTC_CENTURY 0x48
<drivers/pc80/mcXXX. […]
Done
File src/southbridge/amd/pi/hudson/fadt.c:
https://review.coreboot.org/c/coreboot/+/74601/comment/273f2765_9fb16f5f
PS1, Line 43: fadt->mon_alrm = 0; /* 0x7e added to cmos.layout */
need to check
Comments about 0x7d and 0x7e were wrong.
52740 Rev 3.06 - March 18, 2016
BKDG for AMD Family 16h Models 30h-3Fh Processors
IO073_x0D RTC Date Alarm
The name reference is for 0x72/0x73 access, but index 0x0d works through 0x70/0x71 too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74601
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I965a83dc8daaa02ad0935bdde5ca50110adb014a
Gerrit-Change-Number: 74601
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 26 Apr 2023 12:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment