Attention is currently required from: Nicholas Chin, Paul Menzel.
Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79745?usp=email )
Change subject: mb/hp: Add Compaq Elite 8300 CMT port ......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/hp/compaq_elite_8300_cmt/early_init.c:
https://review.coreboot.org/c/coreboot/+/79745/comment/a62564c1_2d691f73?usp... : PS14, Line 11: { 1, 0, 0 }, : { 1, 0, 0 }, : { 1, 0, 1 }, : { 1, 0, 1 }, : { 1, 0, 2 }, : { 1, 0, 2 }, : { 1, 0, 3 }, : { 1, 0, 3 }, : { 1, 0, 4 }, : { 1, 0, 4 }, : { 1, 0, 6 }, : { 1, 0, 5 }, : { 1, 0, 5 }, : { 1, 0, 6 },
Move to devicetree, refer to commit c36b5ea18983 (mb/*: Copy bd82x6x boards' USB port config into de […]
After doing that, it no longer builds:
coreboot main $ make Updating git submodules. HOSTCC util/sconfig/lex.yy.o HOSTCC util/sconfig/sconfig.tab.o HOSTCC util/sconfig/main.o HOSTCC util/sconfig/sconfig (link) SCONFIG mainboard/hp/compaq_elite_8300_cmt/devicetree.cb ERROR: Duplicate device! (null) make: *** [Makefile.mk:763: build/mainboard/hp/compaq_elite_8300_cmt/static.c] Error 1