Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42686 )
Change subject: soc/amd/common: Refactor GPIO_MASTER_SWITCH interrupt enable
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42686/5/src/soc/amd/common/block/gp...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42686/5/src/soc/amd/common/block/gp...
PS5, Line 110: master_reg
Isn't it a little hacky to proxy the register address through as a GPIO offset?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I754a2f6bbee12d637f8c99a9d330ab0ac8187247
Gerrit-Change-Number: 42686
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 17:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment