Change in coreboot[master]: soc/amd/picasso: fix GPE snapshot state

[Aaron Durbin (Code Review)]

Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44533 )

Change subject: soc/amd/picasso: fix GPE snapshot state
......................................................................

soc/amd/picasso: fix GPE snapshot state

In CB:44488 the cbmem addition was re-filling the object
when it should be memcpy()ing from static object. Correct
that oversight. The side effect from the previous implementation
would be if FSP-M modified the GPE state.

BUG=b:159947207

Signed-off-by: Aaron Durbin 
Change-Id: I158a89ae28431896fa9b5789292000fcbf0b066d
---
M src/soc/amd/picasso/romstage.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44533/1

diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c
index 6178220..5a9f051 100644
--- a/src/soc/amd/picasso/romstage.c
+++ b/src/soc/amd/picasso/romstage.c
@@ -31,7 +31,7 @@
    state = cbmem_add(CBMEM_ID_POWER_STATE, sizeof(*state));

if (state)
-		acpi_fill_pm_gpe_state(state);
+		memcpy(state, &chipset_state, sizeof(*state));
 }

ROMSTAGE_CBMEM_INIT_HOOK(add_chipset_state_cbmem);

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44533 )

Change subject: soc/amd/picasso: fix GPE snapshot state
......................................................................

Patch Set 1: Code-Review+2

[Aaron Durbin (Code Review)]

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44533 )

Change subject: soc/amd/picasso: fix GPE snapshot state
......................................................................

soc/amd/picasso: fix GPE snapshot state

In CB:44488 the cbmem addition was re-filling the object
when it should be memcpy()ing from static object. Correct
that oversight. The side effect from the previous implementation
would be if FSP-M modified the GPE state.

BUG=b:159947207

Signed-off-by: Aaron Durbin 
Change-Id: I158a89ae28431896fa9b5789292000fcbf0b066d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44533
Reviewed-by: Furquan Shaikh 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/picasso/romstage.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c
index 6178220..5a9f051 100644
--- a/src/soc/amd/picasso/romstage.c
+++ b/src/soc/amd/picasso/romstage.c
@@ -31,7 +31,7 @@
    state = cbmem_add(CBMEM_ID_POWER_STATE, sizeof(*state));

if (state)
-		acpi_fill_pm_gpe_state(state);
+		memcpy(state, &chipset_state, sizeof(*state));
 }

ROMSTAGE_CBMEM_INIT_HOOK(add_chipset_state_cbmem);