Attention is currently required from: zanxi chen. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59044 )
Change subject: mb/google/trogdor: Adjust mipi panel backlight gpio ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/59044/comment/e3c58dc6_877bc52d PS5, Line 16: #define GPIO_TP_EN GPIO(85) This should be under the #if below, and set to dead_code_t(gpio_t) for eDP boards.
File src/mainboard/google/trogdor/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59044/comment/aa893d37_20807e42 PS5, Line 18: gpio_output(GPIO_TP_EN, 0); Is this necessary? This pin should already be a pull-down on reset.
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59044/comment/dc8864c0_148d7f3e PS5, Line 145: if (CONFIG(BOARD_GOOGLE_MRBLAND) || CONFIG(BOARD_GOOGLE_WORMDINGLER)) Why not TROGDOR_HAS_MIPI_PANEL? I hope this part is the same across all MIPI variants?