Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69507 )
Change subject: soc/amd/psp_smm_gen2.c: Fix 64bit mode integer conversion ......................................................................
soc/amd/psp_smm_gen2.c: Fix 64bit mode integer conversion
Explicitly cast integers to fix building for long mode.
Change-Id: I9f56e183563c943d1c2bd0478c41a80512b47c5e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/amd/common/block/psp/psp_smm_gen2.c 1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/69507/1
diff --git a/src/soc/amd/common/block/psp/psp_smm_gen2.c b/src/soc/amd/common/block/psp/psp_smm_gen2.c index f02723a..6bf079d5 100644 --- a/src/soc/amd/common/block/psp/psp_smm_gen2.c +++ b/src/soc/amd/common/block/psp/psp_smm_gen2.c @@ -4,6 +4,7 @@ #include <amdblocks/acpimmio.h> #include <amdblocks/psp.h> #include <amdblocks/smi.h> +#include <stdint.h>
void soc_fill_smm_trig_info(struct smm_trigger_info *trig) { @@ -13,8 +14,8 @@ trig->address = (uintptr_t)acpimmio_smi + SMI_REG_SMITRIG0; trig->address_type = SMM_TRIGGER_MEM; trig->value_width = SMM_TRIGGER_DWORD; - trig->value_and_mask = ~SMITRIG0_PSP; - trig->value_or_mask = SMITRIG0_PSP; + trig->value_and_mask = (uint32_t)~SMITRIG0_PSP; + trig->value_or_mask = (uint32_t)SMITRIG0_PSP; }
void soc_fill_smm_reg_info(struct smm_register_info *reg)