Attention is currently required from: Felix Singer, Shelley Chen, Ravi kumar.
Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59556 )
Change subject: mb/google/herobrine: Add senor support QUP FW for I2C and SPI
......................................................................
Patch Set 12:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59556/comment/e00b3f4c_99834ac6
PS5, Line 7: src/mainboard/herobrine
mb/google/herobrine
Ack
Patchset:
PS12:
can you please review once
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59556/comment/67147816_670f23bf
PS11, Line 81:
nit: Can you align this properly? No need for all these extra tabs...
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59556
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6fdd09bb437547e6d12eb60c4b2917d2a3074618
Gerrit-Change-Number: 59556
Gerrit-PatchSet: 12
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Thu, 27 Jan 2022 17:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment