[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoga: Modify P sensor setting - coreboot-gerrit

7 Aug 2024


      Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik.
Leo Chou has posted comments on this change by Leo Chou. ( https://review.coreboot.org/c/coreboot/+/83794?usp=email )
Change subject: mb/google/nissa/var/pujjoga: Modify P sensor setting
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83794/comment/ccef3c74_00815758?usp... :
PS5, Line 11: PAD_CFG_GPI_APIC
...
describe why original setting not work?
The original is input pin,not a ACPI irq pin, 
This incorrect configuration prevents the CPU from entering the C8 state properly. thanks.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83794?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3610180c8cf99eba9367e26bfc3666410af19f7
Gerrit-Change-Number: 83794
Gerrit-PatchSet: 5
Gerrit-Owner: Leo Chou leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Jayvik Desai jayvik@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj rishikaraj@google.com
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-CC: Nikki Huang nikki.huang@lcfc.corp-partner.google.com
Gerrit-CC: Roger Wang roger2.wang@lcfc.corp-partner.google.com
Gerrit-Attention: Jayvik Desai jayvik@google.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Rishika Raj rishikaraj@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Derek Huang derekhuang@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Comment-Date: Wed, 07 Aug 2024 07:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai ericllai@google.com