Attention is currently required from: Felix Held, Nicholas Sudsgaard.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80344?usp=email )
Change subject: superio/ite: Add IT8629E
......................................................................
Patch Set 9:
(1 comment)
File src/superio/ite/it8629e/Kconfig:
https://review.coreboot.org/c/coreboot/+/80344/comment/698bb1c1_750ee0cb :
PS9, Line 3: # Unfortunately, the datasheet for IT8629E is not public . Therefore, we will
: # use the functionally closest chip (i.e. IT8728F) as a reference and try to
: # reverse-engineer where necessary.
:
: # IT8629E seems to be very similar to IT8628E (again, no public datasheets), as
: # the chip id is 0x8628.
Please remove that from here and add it to the commit message. Do you know of any differences? If so, please document that as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80344?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44d0377da11f0e118017caa4357012df9373b322
Gerrit-Change-Number: 80344
Gerrit-PatchSet: 9
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 21 Feb 2024 07:55:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment