Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48749 )
Change subject: soc/intel/cnl: add panel and backlight configuration code
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48749/4/src/soc/intel/cannonlake/gr...
File src/soc/intel/cannonlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/48749/4/src/soc/intel/cannonlake/gr...
PS4, Line 16: config_of
Will never return NULL, so the `if (!conf)` check on line 22 is redundant. […]
good catch! I'll add a warning instead below, so a failure won't be unnoticed (well, a black screen will be noticed ofc but it's good to log the reason)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48749
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If619b28478b4b0d18f28f318c16336e0de76e129
Gerrit-Change-Number: 48749
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Dec 2020 14:58:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment