Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57345 )
Change subject: driver/intel/pmc_mux/conn: Add type-c port info to cbmem ......................................................................
Patch Set 12:
(5 comments)
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/f81304cd_28bc16ba PS5, Line 115: mux = pmc->link_list->children;
I was seeing .final being called after each port was registered. […]
Done
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/9400db5d_72077633 PS7, Line 99: {
Oh right sorry forgot about that one 😊 putting port_count there in the struct makes sense.
Done
https://review.coreboot.org/c/coreboot/+/57345/comment/fc7a4ab4_d18a9007 PS7, Line 104:
Done
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/55ad2470_e246127f PS8, Line 28: lb_type_c_info
`type_c_info` should be fine. We don't need lb_type_c_info.
Done
https://review.coreboot.org/c/coreboot/+/57345/comment/c1293509_0cb850d6 PS8, Line 44: ==
=?
Done
-
Nick Vaccaro (Code Review)