Attention is currently required from: Tarun Tuli, Sumeet R Pawnikar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 )
Change subject: soc/intel/meteoerlake: set power limits dynamically ......................................................................
Patch Set 1:
(7 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/74380/comment/a747c71a_0c5f6627 PS1, Line 23: MTL_P_682_45W_CORE, this is not POR for us, I would avoid adding it now to avoid the maintenance
https://review.coreboot.org/c/coreboot/+/74380/comment/1d7d4a6b_5ca04876 PS1, Line 26: MTL_P_682_28W_CORE, same
https://review.coreboot.org/c/coreboot/+/74380/comment/e26d2f22_f008c1bc PS1, Line 33: TDP_28W = 28, same
https://review.coreboot.org/c/coreboot/+/74380/comment/baa779cf_e010fa16 PS1, Line 34: TDP_45W = 45 same
https://review.coreboot.org/c/coreboot/+/74380/comment/44b55502_bfa11103 PS1, Line 43: { PCI_DID_INTEL_MTL_P_ID_1, MTL_P_682_45W_CORE, TDP_45W }, same
https://review.coreboot.org/c/coreboot/+/74380/comment/23838bef_b54a22de PS1, Line 45: { PCI_DID_INTEL_MTL_P_ID_3, MTL_P_482_CORE, TDP_28W }, : { PCI_DID_INTEL_MTL_P_ID_4, MTL_P_682_28W_CORE, TDP_28W }, same
File src/soc/intel/meteorlake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/74380/comment/88ad671a_836ea2ca PS1, Line 12: register "power_limits_config[MTL_P_682_45W_CORE]" = "{ : .tdp_pl1_override = 45, : .tdp_pl2_override = 115, : .tdp_pl4 = 197, : }" i don't even know if anyone is/will be using 45W part.
lets add when it requires