Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85537?usp=email )
Change subject: mb/google/brya/uldrenite: Add WWAN RW350R-GL power on sequence
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/uldrenite/variant.c:
https://review.coreboot.org/c/coreboot/+/85537/comment/96da98d6_9238ef1a?usp... :
PS1, Line 24: variant_init
looks like we will increase the boot time by 50ms. this is 5% of total boot time. Can't this be managed by ACPI code at runtime ? why we need to perform the WWAN init seq in AP FW ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85537?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If8695920c2b3d2a27da62afcbe75e70d1ea09792
Gerrit-Change-Number: 85537
Gerrit-PatchSet: 1
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 09 Dec 2024 16:29:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No