Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47368 )
Change subject: src/drivers/intel: Correct Kconfig option in Makefile ......................................................................
src/drivers/intel: Correct Kconfig option in Makefile
This Kconfig option was just added incorrectly, so would never add the verstage.c file.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I4c39dca9d429ed786ea42c0d421d6ee815e8c419 --- M src/drivers/intel/fsp1_1/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/47368/1
diff --git a/src/drivers/intel/fsp1_1/Makefile.inc b/src/drivers/intel/fsp1_1/Makefile.inc index 86d1f2f7..5fc100a 100644 --- a/src/drivers/intel/fsp1_1/Makefile.inc +++ b/src/drivers/intel/fsp1_1/Makefile.inc @@ -4,7 +4,7 @@
verstage-y += car.c verstage-y += fsp_util.c -verstage-$(CONFIG_SEPARATE_VERSTAGE) += verstage.c +verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += verstage.c
bootblock-$(CONFIG_USE_GENERIC_FSP_CAR_INC) += cache_as_ram.S bootblock-y += fsp_util.c
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47368 )
Change subject: src/drivers/intel: Correct Kconfig option in Makefile ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47368 )
Change subject: src/drivers/intel: Correct Kconfig option in Makefile ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47368 )
Change subject: src/drivers/intel: Correct Kconfig option in Makefile ......................................................................
src/drivers/intel: Correct Kconfig option in Makefile
This Kconfig option was just added incorrectly, so would never add the verstage.c file.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I4c39dca9d429ed786ea42c0d421d6ee815e8c419 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47368 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/intel/fsp1_1/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_1/Makefile.inc b/src/drivers/intel/fsp1_1/Makefile.inc index 86d1f2f7..5fc100a 100644 --- a/src/drivers/intel/fsp1_1/Makefile.inc +++ b/src/drivers/intel/fsp1_1/Makefile.inc @@ -4,7 +4,7 @@
verstage-y += car.c verstage-y += fsp_util.c -verstage-$(CONFIG_SEPARATE_VERSTAGE) += verstage.c +verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += verstage.c
bootblock-$(CONFIG_USE_GENERIC_FSP_CAR_INC) += cache_as_ram.S bootblock-y += fsp_util.c
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)