Change in coreboot[master]: mb/msi/ms7d25: add basic FSP configuration in devicetree - coreboot-gerrit

12 Apr 2022


      Attention is currently required from: Michał Kopeć.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63499 )
Change subject: mb/msi/ms7d25: add basic FSP configuration in devicetree
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/msi/ms7d25/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63499/comment/adf0c6b4_cc038c3e 
PS7, Line 12: USB2_PORT_MID
Those macros will probably need to be revisited. Some headers will have long cables attached to them. Some ports are USB-C.
https://review.coreboot.org/c/coreboot/+/63499/comment/15909a15_2812688b 
PS7, Line 12: OC_SKIP
Also we need to pass OC pins
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff227c70d0155ac27d6ffa50a069d154bb7fce3c
Gerrit-Change-Number: 63499
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 10:42:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment