Attention is currently required from: Angel Pons, Lean Sheng Tan, Maximilian Brune, Paul Menzel, Tim Wawrzynczak.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66545?usp=email )
Change subject: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC
......................................................................
Patch Set 21:
(2 comments)
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/66545/comment/37cbe1ce_ee2c5195 :
PS21, Line 80: select INTEL_CAR_NEM
Move before MAINBOARD_USES_IFD_EC_REGION to maintain alphabetical order
File src/mainboard/intel/adlrvp/devicetree_s.cb:
https://review.coreboot.org/c/coreboot/+/66545/comment/731f3d29_ab029672 :
PS21, Line 2: #TODO if another AlderLake-S RVP is ported, check for similarities
This shouldn't be here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66545?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1f62d6dd0b00d26f8c8a71b624ba5fba4c63774
Gerrit-Change-Number: 66545
Gerrit-PatchSet: 21
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 05 Jun 2023 13:50:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment