Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63564 )
Change subject: mb/google/brya: Add missing parameter name to variant_generate_s0ix_hook ......................................................................
mb/google/brya: Add missing parameter name to variant_generate_s0ix_hook
Fixes the following build error:
src/mainboard/google/brya/mainboard.c: In function 'variant_generate_s0ix_hook': src/mainboard/google/brya/mainboard.c:157:40: error: parameter name omitted void __weak variant_generate_s0ix_hook(enum s0ix_entry) ^~~~~~~~~~~~~~~
BUG=None TEST=`abuild -a -x -c max -p none -t google/brya` now succeeds
Change-Id: Id578766e2a3b7647e920740dde3e356a7db39d4d Signed-off-by: Reka Norman rekanorman@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/63564 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/mainboard.c b/src/mainboard/google/brya/mainboard.c index b3f42ca..d85dc05 100644 --- a/src/mainboard/google/brya/mainboard.c +++ b/src/mainboard/google/brya/mainboard.c @@ -154,7 +154,7 @@ /* Add board-specific SSDT entries */ }
-void __weak variant_generate_s0ix_hook(enum s0ix_entry) +void __weak variant_generate_s0ix_hook(enum s0ix_entry entry) { /* Add board-specific MS0X entries */ /* diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h index baf0597..b088ecb 100644 --- a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h @@ -29,7 +29,7 @@ S0IX_ENTRY, };
-void variant_generate_s0ix_hook(enum s0ix_entry); +void variant_generate_s0ix_hook(enum s0ix_entry entry);
/* Modify devictree settings during ramstage */ void variant_devtree_update(void);