Attention is currently required from: Wisley Chen. Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/59349
to review the following change.
Change subject: [TEST] mb/google/brya/var/redrix: exchange i2c port for touchscreen/cr50 ......................................................................
[TEST] mb/google/brya/var/redrix: exchange i2c port for touchscreen/cr50
Exchange i2c port for touchscreen and cr50.
BUG=none TEST=build
Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com Change-Id: I8f3a1a20d98cd4cbfa6fc7cc31cb688761f9f763 --- M src/mainboard/google/brya/variants/redrix/overridetree.cb 1 file changed, 40 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/59349/1
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index 77e44e3..33c6695 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -255,8 +255,17 @@ register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" - device i2c 0x15 on end + device i2c 0x15 on + probe HW_PHASE HW_PRE_DVT + end end + chip drivers/i2c/tpm + register "hid" = ""GOOG0005"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A13_IRQ)" + device i2c 50 on + probe HW_PHASE HW_AFTER_DVT + end + end end device ref i2c2 on chip drivers/intel/mipi_camera @@ -358,6 +367,36 @@ end
end + device ref i2c3 on + chip drivers/i2c/tpm + register "hid" = ""GOOG0005"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A13_IRQ)" + device i2c 50 on + probe HW_PHASE HW_PRE_DVT + end + end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN2513"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" + register "generic.reset_delay_ms" = "300" + register "generic.reset_off_delay_ms" = "1" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" + register "generic.enable_delay_ms" = "6" + register "generic.stop_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" + register "generic.stop_off_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 0x15 on + probe HW_PHASE HW_AFTER_DVT + end + end + end device ref i2c5 on chip drivers/i2c/generic register "hid" = ""ELAN0000""