Attention is currently required from: Deepti Deshatty, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Li1 Feng, Nick Vaccaro, Rishika Raj, V Sowmya, Varun Upadhyay, Yuval Peress.
Subrata Banik has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83671?usp=email )
Change subject: mb/google/trulo: support ISH
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83671/comment/b297333d_3f2f2979?usp... :
PS2, Line 50: trulo_ish
my review comment from other cl https://review.coreboot.org/c/coreboot/+/83656/comment/88a16bc9_bba5f182/
better to get a clarification from intel team on this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83671?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id60cb416a1cce5407bd483f0ce54f477584459b1
Gerrit-Change-Number: 83671
Gerrit-PatchSet: 2
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Yuval Peress
peress@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Yuval Peress
peress@google.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Comment-Date: Wed, 31 Jul 2024 02:17:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No