Attention is currently required from: Philipp Deppenwiese, Martin Roth, Paul Menzel, Angel Pons, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51923 )
Change subject: security/tpm: Add option to init TPM in bootblock
......................................................................
Patch Set 6:
(1 comment)
File src/lib/bootblock.c:
https://review.coreboot.org/c/coreboot/+/51923/comment/fccffa1c_9a43583d
PS6, Line 62: acpi_is_wakeup_s3
I'm not sure if we can detect S3 resume this early
Huh, it looks like this would fail on sb/intel. soc/intel does implement this correctly. #yetanothercleanuptodo
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51923
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifacba5d9ab19b47968b4f2ed5731ded4aac55022
Gerrit-Change-Number: 51923
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 05 May 2021 08:26:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment