Attention is currently required from: Tarun Tuli, Kapil Porwal.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74370 )
Change subject: soc/intel/meteorlake: Replace assert with error message
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/74370/comment/032d64d7_2ee41a62
PS2, Line 568: if (!s_cfg->CnviMode && s_cfg->CnviWifiCore)
IIRC why we do this before is this will cause FSP/kernel panic. So we put assert at first time. But not sure about MTL FSP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49a988b7eda009456d438ba7be0d2918826e1c36
Gerrit-Change-Number: 74370
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 12:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment