Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83714?usp=email )
Change subject: soc/intel/cnvi: Add SBTE Method
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/cnvi/cnvi.c:
https://review.coreboot.org/c/coreboot/+/83714/comment/847168e4_6a993cf9?usp... :
PS5, Line 284: // TODO: ADL PCH S is 0x08030000,
should be able to use an `if CONFIG()` check for the PCH
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83714?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I11cdf654223daa7b417d6aa18855b48b50a8faa4
Gerrit-Change-Number: 83714
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Fri, 02 Aug 2024 13:57:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No