Attention is currently required from: Christian Walter, Julius Werner, Nick Vaccaro, Paul Menzel, Paz Zcharya, Tim Van Patten.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79736?usp=email )
Change subject: security/tpm: Retrieve factory configuration for device w/ Google TPM
......................................................................
Patch Set 5:
(3 comments)
File src/security/tpm/tss/tcg-2.0/tss_structures.h:
https://review.coreboot.org/c/coreboot/+/79736/comment/0a8df00e_e4c539fb :
PS5, Line 361: uint64_t factory_config;
Why are you doing it like this? Unless I'm missing something here I think you should just put it ins […]
Acknowledged
File src/security/tpm/tss/vendor/cr50/cr50.c:
https://review.coreboot.org/c/coreboot/+/79736/comment/4109e8d1_754487ac :
PS5, Line 186: printk(BIOS_INFO, "Reading factory config\n");
Actually, the caching would probably better be done in chromeos_get_factory_config(), if anything.
Acknowledged
https://review.coreboot.org/c/coreboot/+/79736/comment/dc555c32_5390da56 :
PS5, Line 196: * ladder.
Is this actually relevant to this command and its use case? Why would the key ladder be disabled her […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79736?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd0e850770152a03aa46d7f8bbb76f7520a59081
Gerrit-Change-Number: 79736
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Paz Zcharya
pazz@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Paz Zcharya
pazz@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Fri, 29 Dec 2023 08:33:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment