Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel - coreboot-gerrit

23 Dec 2021


      Attention is currently required from: V sujith kumar Reddy, Raul Rangel.
Yu-hsuan Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60072 )
Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60072/comment/131fef44_fe160175 
PS4, Line 8: 
It should be better to add the bug and test field like other changes here.
File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c:
https://review.coreboot.org/c/coreboot/+/60072/comment/46d1da3e_184c2cfe 
PS4, Line 38: enspkr_gpio
dmic_select_gpio?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60072
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a
Gerrit-Change-Number: 60072
Gerrit-PatchSet: 4
Gerrit-Owner: V sujith kumar Reddy vsujithkumar.reddy@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Yu-hsuan Hsu yuhsuan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: V sujith kumar Reddy vsujithkumar.reddy@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Comment-Date: Thu, 23 Dec 2021 04:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment