Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons, Julius Werner.
Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50210 )
Change subject: drivers/i2c: sx9310: Use open source variables
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50210/comment/f035890b_15da653c
PS3, Line 7: drivers/i2c: sx9310: Use open source variables
I guess it's about using more descriptive names
yes, the original driver in the kernel was using chip registers map to configure the SAR sensor, which is opaque, especially when the datasheet is not published widely.
File src/drivers/i2c/sx9310/sx9310.c:
https://review.coreboot.org/c/coreboot/+/50210/comment/46e8e038_183847a2
PS3, Line 70: * proximity/semtech,sx9310.yaml
Where? In the Linux kernel?
Yes: https://www.kernel.org/doc/Documentation/devicetree/bindings/iio/proximity/s...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d1c81b56eaeef1dbb0f73c1d74c3a20e8b2fd7b
Gerrit-Change-Number: 50210
Gerrit-PatchSet: 3
Gerrit-Owner: Gwendal Grignou
gwendal@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 01 Mar 2021 06:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment