Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84048?usp=email )
Change subject: arch/x86/car.ld: Fix overlapping regions ......................................................................
arch/x86/car.ld: Fix overlapping regions
The fspm_rc_heap is already accounted for inside .car.data. Some linkers like LLD do not like overlapping regions so remove this.
Change-Id: I058bd6790afc313e06f1888e5b783d97b7e93b1e Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/84048 Reviewed-by: Shuo Liu shuo.liu@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/arch/x86/car.ld 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: Shuo Liu: Looks good to me, but someone else must approve build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld index f99304f..9d54037 100644 --- a/src/arch/x86/car.ld +++ b/src/arch/x86/car.ld @@ -113,11 +113,6 @@ _car_region_end = . + CONFIG_DCACHE_RAM_SIZE - (. - _car_region_start) - CONFIG_FSP_T_RESERVED_SIZE;
-. = _car_region_start; -.car.fspm_rc_heap . (NOLOAD) : { - . += CONFIG_FSP_M_RC_HEAP_SIZE; -} - . = _car_region_end; .car.mrc_var . (NOLOAD) : { . += CONFIG_DCACHE_RAM_MRC_VAR_SIZE;