Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60415 )
Change subject: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS ......................................................................
Patch Set 1:
(7 comments)
File src/mainboard/google/volteer/variants/collis/overridetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/3d306a56_9beefc8c PS1, Line 201: probe AUDIO MAX98373_ALC5682IVS_I2S_UP4 trailing whitespace
File src/mainboard/google/volteer/variants/collis/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/5cebc0cc_a6e73082 PS1, Line 8: struct device *codec = DEV_PTR(audio_codec); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/deba3080_35346cb7 PS1, Line 8: struct device *codec = DEV_PTR(audio_codec); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/79c671f1_a28e63c8 PS1, Line 9: struct drivers_i2c_generic_config *config; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/790e7c52_4f9e5513 PS1, Line 9: struct drivers_i2c_generic_config *config; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/7a20c074_6c75648a PS1, Line 11: config = codec->chip_info; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136372): https://review.coreboot.org/c/coreboot/+/60415/comment/2e8cb843_508fcdc7 PS1, Line 11: config = codec->chip_info; please, no spaces at the start of a line