[M] Change in coreboot[main]: RFC: util/autoport: Utilize text/template module - coreboot-gerrit

11 Aug 2024


      Attention is currently required from: Nicholas Chin.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83279?usp=email )
Change subject: RFC: util/autoport: Utilize text/template module
......................................................................
Patch Set 3:
(1 comment)
File util/autoport/templates/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/83279/comment/b5a79c5e_86073ed0?usp... :
PS3, Line 9: len .PinConfig
...
This is incorrect, as the original code used the length of PinConfig + 1 to account for the AZALIA_S […]
Can it be increased by 1 before passing it over?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83279?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15934c6ebc8a599dbe1c578481de48f135d97232
Gerrit-Change-Number: 83279
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Comment-Date: Sun, 11 Aug 2024 17:39:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin nic.c3.14@gmail.com