Attention is currently required from: Sunwei Li, Henry Sun, Weimin Wu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56795 )
Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for multi audio codec
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/dedede/variants/cappy2/gpio.c:
https://review.coreboot.org/c/coreboot/+/56795/comment/07afad10_de9e014b
PS6, Line 25: PAD_NC(GPP_D18, NONE),
What is in D18?
https://review.coreboot.org/c/coreboot/+/56795/comment/8f685e7c_f6c1c8c2
PS6, Line 36: BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL);
I believe the change here works well with CB:56616 i.e. both the changes are taking effect.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9121e75eaf46b43e6dc5ef2e31029a153c7a807d
Gerrit-Change-Number: 56795
Gerrit-PatchSet: 6
Gerrit-Owner: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 05 Aug 2021 18:45:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment