Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31359
Change subject: mb/google/octopus/casta: Tune usb2eye setting ......................................................................
mb/google/octopus/casta: Tune usb2eye setting
It needs to tune usb2eye setting for these ports: USB2[4] - type-c port USB2[6] - camera
BUG=NONE BRANCH=octopus TEST=built and passed usb2eye SI test
Change-Id: Iaa3adaab2f391e95730b141dc0237ca62c459e5a Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31359/1
diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb index d70a6ea..dc9c911 100644 --- a/src/mainboard/google/octopus/variants/casta/overridetree.cb +++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb @@ -1,4 +1,22 @@ chip soc/intel/apollolake + # Override USB2 PER PORT register (PORT 4) + register "usb2eye[4]" = "{ + .Usb20OverrideEn = 1, + .Usb20PerPortPeTxiSet = 7, + .Usb20PerPortTxiSet = 3, + .Usb20IUsbTxEmphasisEn = 3, + .Usb20PerPortTxPeHalf = 0, + }" + + # Override USB2 PER PORT register (PORT 6) + register "usb2eye[6]" = "{ + .Usb20OverrideEn = 1, + .Usb20PerPortPeTxiSet = 3, + .Usb20PerPortTxiSet = 0, + .Usb20IUsbTxEmphasisEn = 3, + .Usb20PerPortTxPeHalf = 0, + }" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value |
shkim has uploaded a new patch set (#2) to the change originally created by Seunghwan Kim. ( https://review.coreboot.org/c/coreboot/+/31359 )
Change subject: mb/google/octopus/casta: Tune usb2eye setting ......................................................................
mb/google/octopus/casta: Tune usb2eye setting
It needs to tune usb2eye setting for these ports: USB2[4] - type-c port USB2[6] - camera
BUG=b:122878632 BRANCH=octopus TEST=built and passed usb2eye SI test
Change-Id: Iaa3adaab2f391e95730b141dc0237ca62c459e5a Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31359/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31359 )
Change subject: mb/google/octopus/casta: Tune usb2eye setting ......................................................................
Patch Set 2: Code-Review+2
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31359 )
Change subject: mb/google/octopus/casta: Tune usb2eye setting ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31359 )
Change subject: mb/google/octopus/casta: Tune usb2eye setting ......................................................................
mb/google/octopus/casta: Tune usb2eye setting
It needs to tune usb2eye setting for these ports: USB2[4] - type-c port USB2[6] - camera
BUG=b:122878632 BRANCH=octopus TEST=built and passed usb2eye SI test
Change-Id: Iaa3adaab2f391e95730b141dc0237ca62c459e5a Signed-off-by: Seunghwan Kim sh_.kim@samsung.com Reviewed-on: https://review.coreboot.org/c/31359 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Justin TerAvest teravest@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Justin TerAvest: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb index d70a6ea..dc9c911 100644 --- a/src/mainboard/google/octopus/variants/casta/overridetree.cb +++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb @@ -1,4 +1,22 @@ chip soc/intel/apollolake + # Override USB2 PER PORT register (PORT 4) + register "usb2eye[4]" = "{ + .Usb20OverrideEn = 1, + .Usb20PerPortPeTxiSet = 7, + .Usb20PerPortTxiSet = 3, + .Usb20IUsbTxEmphasisEn = 3, + .Usb20PerPortTxPeHalf = 0, + }" + + # Override USB2 PER PORT register (PORT 6) + register "usb2eye[6]" = "{ + .Usb20OverrideEn = 1, + .Usb20PerPortPeTxiSet = 3, + .Usb20PerPortTxiSet = 0, + .Usb20IUsbTxEmphasisEn = 3, + .Usb20PerPortTxPeHalf = 0, + }" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value |
-
Furquan Shaikh (Code Review) -
Justin TerAvest (Code Review)
-
Patrick Georgi (Code Review)
-
Seunghwan Kim (Code Review)
-
shkim (Code Review)