Attention is currently required from: Hung-Te Lin, Marc Jones, Furquan Shaikh, Jack Rosenthal, Julius Werner.
Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56904 )
Change subject: include/bcd: move bcd code to commonlib/bsd/include
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Thanks. fixed.
Note: added in the commit description a link to the FreeBSD code where they use bin2bcd/bcd2bin.
File src/commonlib/bsd/include/commonlib/bsd/bcd.h:
https://review.coreboot.org/c/coreboot/+/56904/comment/bb259298_fdbc28b4
PS1, Line 1: GPL-2.0-only
Needs changed to BSD
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56904
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72
Gerrit-Change-Number: 56904
Gerrit-PatchSet: 2
Gerrit-Owner: Ricardo Quesada
ricardoq@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marc Jones
marc.jones@amd.corp-partner.google.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marc Jones
marc.jones@amd.corp-partner.google.com
Gerrit-Attention: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 11 Aug 2021 16:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jack Rosenthal
jrosenth@chromium.org
Gerrit-MessageType: comment