Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 )
Change subject: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/29662/5/src/soc/intel/braswell/bootblock/cac... File src/soc/intel/braswell/bootblock/cache_as_ram_cbootblock.S:
https://review.coreboot.org/#/c/29662/5/src/soc/intel/braswell/bootblock/cac... PS5, Line 21: #include <device/pci_def.h>
Specific support (provide timestamp, bootblock_pre_c_entry label) for C bootblock is required.
I don't see why it's specific to braswell. Can you place it in drivers/intel/fsp1_1 ? That way all FSP1.1 can share the same code and be migrated to c bootblock.
-
Patrick Rudolph (Code Review)