Change in coreboot[master]: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kevin Chiu (Code Review)

27 Aug 2020 27 Aug '20

4:25 p.m.

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD ......................................................................

mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD

BUG=b:165956925 BRANCH=zork TEST=emerge-zork coreboot

Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- A src/mainboard/google/zork/spd/micron-MT40A1G16RC-062E-B.spd.hex 1 file changed, 33 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44861/1

diff --git a/src/mainboard/google/zork/spd/micron-MT40A1G16RC-062E-B.spd.hex b/src/mainboard/google/zork/spd/micron-MT40A1G16RC-062E-B.spd.hex new file mode 100644 index 0000000..8483e99 --- /dev/null +++ b/src/mainboard/google/zork/spd/micron-MT40A1G16RC-062E-B.spd.hex @@ -0,0 +1,33 @@ +# Micron MT40A1G16KD-062E:E +23 11 0C 03 46 29 00 08 00 60 00 03 02 03 00 00 +00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 40 36 +0F 01 1F 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 21 7D +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 4D 54 34 30 41 31 47 +31 36 52 43 2D 30 36 32 45 3A 42 20 20 31 80 2C +42 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Attachments:

attachment.htm (text/html — 5.4 KB)

Show replies by date

Kevin Chiu (Code Review)

27 Aug 27 Aug

4:40 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44861

to look at the new patch set (#2).

Change subject: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD ......................................................................

mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD

BUG=b:165956925 BRANCH=zork TEST=emerge-zork coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44861/2

Aaron Durbin (Code Review)

5:41 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD ......................................................................

Patch Set 2:

Hi Kevin, we're in the process of moving to a better tool to manage spds. Please see https://review.coreboot.org/c/coreboot/+/44447 (namely util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt) for how to add the necessary information.

What's the schedule for needing this part's support?

Kevin Chiu (Code Review)

5:46 p.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD ......................................................................

Patch Set 2:

...

Patch Set 2:

Hi Kevin, we're in the process of moving to a better tool to manage spds. Please see https://review.coreboot.org/c/coreboot/+/44447 (namely util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt) for how to add the necessary information.

What's the schedule for needing this part's support?

Hi Aaron, we're planning to add this DRAM for the next build around mid of Sep. thank you!

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 27 Aug 2020 17:46:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aaron Durbin (Code Review)

6:36 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD ......................................................................

Patch Set 2:

...

Patch Set 2:

...
Patch Set 2:

Hi Kevin, we're in the process of moving to a better tool to manage spds. Please see https://review.coreboot.org/c/coreboot/+/44447 (namely util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt) for how to add the necessary information.

What's the schedule for needing this part's support?

Hi Aaron, we're planning to add this DRAM for the next build around mid of Sep. thank you!

Thanks, Kevin. I think we should be good by waiting a little bit of time. Can you look into formulating a CL which adds that part to global_ddr4_mem_parts.json.txt ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 27 Aug 2020 18:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rob Barnes (Code Review)

28 Aug 28 Aug

2:47 p.m.

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD ......................................................................

Patch Set 2:

https://review.coreboot.org/c/coreboot/+/44447 just merged. Please make this change in global_ddr4_mem_parts.json.txt.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 28 Aug 2020 14:47:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rob Barnes (Code Review)

4 Sep 4 Sep

4:48 a.m.

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD ......................................................................

Patch Set 2: Code-Review-1

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 04 Sep 2020 04:48:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

10:27 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: mb/google/zork: add DDR4 3200 MT40A1G16RC-062E-B 16Gb SPD ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44861/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44861/2//COMMIT_MSG@7 PS2, Line 7: 16Gb 16GB

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 04 Sep 2020 10:27:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

30 Mar 30 Mar

1:07 p.m.

New subject: Change in coreboot[master]: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb ......................................................................

Patch Set 5:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Mar 2021 13:07:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rob Barnes (Code Review)

3:11 p.m.

New subject: Change in coreboot[master]: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Attention is currently required from: Kevin Chiu. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb ......................................................................

Patch Set 5:

(1 comment)

File util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt:

https://review.coreboot.org/c/coreboot/+/44861/comment/05a61ae5_c2719d01 PS5, Line 227: "packageBusWidth": 64, Bus width should be 16.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Comment-Date: Tue, 30 Mar 2021 15:11:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

4:18 p.m.

New subject: Change in coreboot[master]: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Attention is currently required from: Kevin Chiu. Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi, Kevin Chiu, Keith Tzeng, Rob Barnes, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44861

to look at the new patch set (#6).

Change subject: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb ......................................................................

util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Add SPD support for Micron DDR4 memory part MT40A1G16RC-062E-B 16Gb

BUG=b:184024142 TEST=none

Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt 1 file changed, 13 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44861/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-MessageType: newpatchset

Kevin Chiu (Code Review)

4:27 p.m.

New subject: Change in coreboot[master]: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Attention is currently required from: Paul Menzel, Rob Barnes. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb ......................................................................

Patch Set 6:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/44861/comment/9a7b61c4_c6cd9fa2 PS2, Line 7: 16Gb

...

16GB

no, it's 16Gb module.

File util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt:

https://review.coreboot.org/c/coreboot/+/44861/comment/2165e7c0_d3e63928 PS5, Line 227: "packageBusWidth": 64,

...

Bus width should be 16.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Rob Barnes robbarnes@google.com Gerrit-Comment-Date: Tue, 30 Mar 2021 16:27:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Rob Barnes robbarnes@google.com Gerrit-MessageType: comment

Kevin Chiu (Code Review)

4:27 p.m.

New subject: Change in coreboot[master]: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Attention is currently required from: Paul Menzel, Rob Barnes. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb ......................................................................

Patch Set 6:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/44861/comment/6ebc76ac_bab3de3e PS2, Line 7: 16Gb

...

no, it's 16Gb module.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Rob Barnes robbarnes@google.com Gerrit-Comment-Date: Tue, 30 Mar 2021 16:27:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu kevin.chiu.17802@gmail.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Rob Barnes (Code Review)

2 Apr 2 Apr

2:35 p.m.

New subject: Change in coreboot[master]: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Attention is currently required from: Kevin Chiu, Paul Menzel. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 7 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 02 Apr 2021 14:35:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 Apr 6 Apr

6:46 a.m.

New subject: Change in coreboot[master]: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44861 )

Change subject: util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb ......................................................................

util: Add DDR4 generic SPD for Micron MT40A1G16RC-062E-B 16Gb

Add SPD support for Micron DDR4 memory part MT40A1G16RC-062E-B 16Gb

BUG=b:184024142 TEST=none

Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44861 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rob Barnes robbarnes@google.com --- M util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt 1 file changed, 13 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Rob Barnes: Looks good to me, approved

diff --git a/util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt b/util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt index b6e0ab1..03c6630 100644 --- a/util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt +++ b/util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt @@ -215,6 +215,18 @@ "packageBusWidth": 16, "ranksPerPackage": 1 } - } + }, + { + // Datasheet Revision: Rev. A 03/2021 EN + "name": "MT40A1G16RC-062E:B", + "attribs": { + "speedMTps": 3200, + "CL_nRCD_nRP": 22, + "capacityPerDieGb": 16, + "diesPerPackage": 1, + "packageBusWidth": 16, + "ranksPerPackage": 1 + } + } ] }

-- To view, visit https://review.coreboot.org/c/coreboot/+/44861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I438310fb74d96953bc83374df3109e4c56192a5f Gerrit-Change-Number: 44861 Gerrit-PatchSet: 9 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1122

days inactive

1344

days old

coreboot-gerrit@coreboot.org

14 comments

5 participants

tags (0)

participants (5)

Aaron Durbin (Code Review)
Kevin Chiu (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Rob Barnes (Code Review)