[XL] Change in coreboot[main]: nb/via/cx700: Implement raminit - coreboot-gerrit

9 Jul 2024


      Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82770?usp=email )
Change subject: nb/via/cx700: Implement raminit
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/via/cx700/raminit.h:
https://review.coreboot.org/c/coreboot/+/82770/comment/19a9793a_5a698497?usp... :
PS2, Line 7: void sdram_enable(const struct dram_cfg *);
...
Should be easy to fix.
You mean I should try to fix checkpatch? :D
Sorry, but I'm all against it when one would just repeat the type name.
I could also name it `x` and checkpatch would probably be happy, that
can't be the point of it.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc36b4f314cdf47f18c8be0fcb98218c50938e94
Gerrit-Change-Number: 82770
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 09 Jul 2024 16:28:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com