[M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu.

Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )

Change subject: soc/intel/common/block/pmc: Add GPE1 functions
......................................................................

Patch Set 10:

(5 comments)

File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/84104/comment/0e55102a_af90fc4c?usp... :
PS3, Line 406: pmc_clear_gpi_gpe0_status
> > Subrata,  […]

Acknowledged

File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/84104/comment/187ee586_e17484a7?usp... :
PS10, Line 296: 
              : /* GPE */
              : __weak const char *const *soc_std_gpe1_sts_array(int idx, size_t *a)
              : {
              : 	return NULL;
              : }
              : 
              : /* disable the corresponding GPE1 bits based on standard GPE0 bits */
              : __weak void soc_pmc_disable_std_gpe1(uint32_t gpe0_mask)
              : {
              : }
              : 
              : /* enable the corresponding GPE1 bits based on standard GPE0 bits */
              : __weak void soc_pmc_enable_std_gpe1(uint32_t gpe0_mask)
              : {
              : }
move this _weak implementation the file beginning and a comment saying `/* SoC overrides for GPE1 when `SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1` enabled */ ?

https://review.coreboot.org/c/coreboot/+/84104/comment/fb29d48e_81a5488e?usp... :
PS10, Line 329: pmc_disable_gpe1
can you please move this API after `pmc_disable_gpe0`?

https://review.coreboot.org/c/coreboot/+/84104/comment/40103227_686bb247?usp... :
PS10, Line 396: reset_std_gpe1_status
move after `reset_std_gpe0_status`

https://review.coreboot.org/c/coreboot/+/84104/comment/55dfb13e_634e1ca2?usp... :
PS10, Line 406: print_std_gpe1_sts
move after `print_std_gpe0_sts`?