Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................
cpu/qemu-x86: Fix timestamp and bist reporting
Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/cpu/qemu-x86/cache_as_ram_bootblock.S 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/43002/1
diff --git a/src/cpu/qemu-x86/cache_as_ram_bootblock.S b/src/cpu/qemu-x86/cache_as_ram_bootblock.S index 30f9f9c..415ed24 100644 --- a/src/cpu/qemu-x86/cache_as_ram_bootblock.S +++ b/src/cpu/qemu-x86/cache_as_ram_bootblock.S @@ -29,11 +29,12 @@
/* Restore the BIST result and timestamps. */ #if defined(__x86_64__) - movd %mm1, %rdi + movd %mm2, %rdi shld %rdi, 32 movd %mm1, %rsi or %rsi, %rdi - movd %mm2, %rsi + + movd %mm0, %rsi #else sub $4, %esp
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8: What is the problem?
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8:
What is the problem?
It's broken.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8:
It's broken.
Why does it not work, though? Where do the correct settings come from?
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8:
Why does it not work, though? Where do the correct settings come from?
It doesn't work as the register in assembly are accidentally swapped. I looked at the code and put in the correct registers. The settings comes from existing assembly code.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................
Patch Set 1: Code-Review+2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8:
It doesn't work as the register in assembly are accidentally swapped. […]
Done
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................
cpu/qemu-x86: Fix timestamp and bist reporting
Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/43002 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/qemu-x86/cache_as_ram_bootblock.S 1 file changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/cpu/qemu-x86/cache_as_ram_bootblock.S b/src/cpu/qemu-x86/cache_as_ram_bootblock.S index 30f9f9c..415ed24 100644 --- a/src/cpu/qemu-x86/cache_as_ram_bootblock.S +++ b/src/cpu/qemu-x86/cache_as_ram_bootblock.S @@ -29,11 +29,12 @@
/* Restore the BIST result and timestamps. */ #if defined(__x86_64__) - movd %mm1, %rdi + movd %mm2, %rdi shld %rdi, 32 movd %mm1, %rsi or %rsi, %rdi - movd %mm2, %rsi + + movd %mm0, %rsi #else sub $4, %esp
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)