Change in coreboot[master]: cpu/qemu-x86: Fix timestamp and bist reporting

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Rudolph (Code Review)

2 Jul 2020 2 Jul '20

6:09 a.m.

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43002 )

Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................

cpu/qemu-x86: Fix timestamp and bist reporting

Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/cpu/qemu-x86/cache_as_ram_bootblock.S 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/43002/1

diff --git a/src/cpu/qemu-x86/cache_as_ram_bootblock.S b/src/cpu/qemu-x86/cache_as_ram_bootblock.S index 30f9f9c..415ed24 100644 --- a/src/cpu/qemu-x86/cache_as_ram_bootblock.S +++ b/src/cpu/qemu-x86/cache_as_ram_bootblock.S @@ -29,11 +29,12 @@

/* Restore the BIST result and timestamps. */ #if defined(__x86_64__) - movd %mm1, %rdi + movd %mm2, %rdi shld %rdi, 32 movd %mm1, %rsi or %rsi, %rdi - movd %mm2, %rsi + + movd %mm0, %rsi #else sub $4, %esp

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Paul Menzel (Code Review)

5 Jul 5 Jul

7:03 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )

Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8: What is the problem?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 05 Jul 2020 07:03:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

8:45 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )

Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8:

...

What is the problem?

It's broken.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 05 Jul 2020 08:45:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Angel Pons (Code Review)

1:35 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )

Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8:

...

It's broken.

Why does it not work, though? Where do the correct settings come from?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 05 Jul 2020 13:35:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

6 Jul 6 Jul

6:24 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )

Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8:

...

Why does it not work, though? Where do the correct settings come from?

It doesn't work as the register in assembly are accidentally swapped. I looked at the code and put in the correct registers. The settings comes from existing assembly code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 06 Jul 2020 06:24:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Arthur Heymans (Code Review)

8:07 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )

Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 06 Jul 2020 20:07:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

14 Aug 14 Aug

6:30 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )

Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8 PS1, Line 8:

...

It doesn't work as the register in assembly are accidentally swapped. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 14 Aug 2020 06:30:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

5:56 p.m.

Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43002 )

Change subject: cpu/qemu-x86: Fix timestamp and bist reporting ......................................................................

cpu/qemu-x86: Fix timestamp and bist reporting

Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/43002 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/qemu-x86/cache_as_ram_bootblock.S 1 file changed, 3 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve

-- To view, visit https://review.coreboot.org/c/coreboot/+/43002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5 Gerrit-Change-Number: 43002 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1592

days inactive

1635

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)