Change in ...coreboot[master]: payloads/coreinfo: Enable -Wextra

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Jacob Garber (Code Review)

28 Jun 2019 28 Jun '19

5:27 p.m.

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33864

Change subject: payloads/coreinfo: Enable -Wextra ......................................................................

payloads/coreinfo: Enable -Wextra

This enables extra useful warnings.

Change-Id: I3d54988935c7df9ac0dc2f7aceb56fb720c9c4d1 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M payloads/coreinfo/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33864/1

diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index 50659d3..1a34dbe 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -83,7 +83,7 @@ LPCC := CC="$(CC)" $(LIBPAYLOAD_OBJ)/bin/lpgcc LPAS := AS="$(AS)" $(LIBPAYLOAD_OBJ)/bin/lpas

-CFLAGS += -Wall -Werror -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES) +CFLAGS += -Wall -Wextra -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES)

ifneq ($(strip $(HAVE_DOTCONFIG)),) include $(src)/.config

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

HAOUAS Elyes (Code Review)

29 Jun 29 Jun

8:04 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33864 )

Change subject: payloads/coreinfo: Enable -Wextra ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33864/1/payloads/coreinfo/Makefile File payloads/coreinfo/Makefile:

https://review.coreboot.org/#/c/33864/1/payloads/coreinfo/Makefile@a86 PS1, Line 86: Please, why -Werror is removed ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d54988935c7df9ac0dc2f7aceb56fb720c9c4d1 Gerrit-Change-Number: 33864 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 29 Jun 2019 08:04:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jacob Garber (Code Review)

5:06 p.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33864 )

Change subject: payloads/coreinfo: Enable -Wextra ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33864/1/payloads/coreinfo/Makefile File payloads/coreinfo/Makefile:

https://review.coreboot.org/#/c/33864/1/payloads/coreinfo/Makefile@a86 PS1, Line 86:

...

Please, why -Werror is removed ?

Oops, good catch

-- To view, visit https://review.coreboot.org/c/coreboot/+/33864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d54988935c7df9ac0dc2f7aceb56fb720c9c4d1 Gerrit-Change-Number: 33864 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 29 Jun 2019 17:06:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Jacob Garber (Code Review)

5:09 p.m.

Hello HAOUAS Elyes, David Hendricks, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33864

to look at the new patch set (#2).

Change subject: payloads/coreinfo: Enable -Wextra ......................................................................

payloads/coreinfo: Enable -Wextra

This enables extra useful warnings.

Change-Id: I3d54988935c7df9ac0dc2f7aceb56fb720c9c4d1 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M payloads/coreinfo/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33864/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d54988935c7df9ac0dc2f7aceb56fb720c9c4d1 Gerrit-Change-Number: 33864 Gerrit-PatchSet: 2 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

5:53 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33864 )

Change subject: payloads/coreinfo: Enable -Wextra ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d54988935c7df9ac0dc2f7aceb56fb720c9c4d1 Gerrit-Change-Number: 33864 Gerrit-PatchSet: 2 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 29 Jun 2019 17:53:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

7 Jul 7 Jul

8:20 p.m.

New subject: Change in coreboot[master]: payloads/coreinfo: Enable -Wextra

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33864 )

Change subject: payloads/coreinfo: Enable -Wextra ......................................................................

payloads/coreinfo: Enable -Wextra

This enables extra useful warnings.

Change-Id: I3d54988935c7df9ac0dc2f7aceb56fb720c9c4d1 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33864 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M payloads/coreinfo/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved

diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index 50659d3..a98342f 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -83,7 +83,7 @@ LPCC := CC="$(CC)" $(LIBPAYLOAD_OBJ)/bin/lpgcc LPAS := AS="$(AS)" $(LIBPAYLOAD_OBJ)/bin/lpas

-CFLAGS += -Wall -Werror -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES) +CFLAGS += -Wall -Wextra -Werror -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES)

ifneq ($(strip $(HAVE_DOTCONFIG)),) include $(src)/.config

-- To view, visit https://review.coreboot.org/c/coreboot/+/33864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d54988935c7df9ac0dc2f7aceb56fb720c9c4d1 Gerrit-Change-Number: 33864 Gerrit-PatchSet: 3 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1777

days inactive

1786

days old

coreboot-gerrit@coreboot.org

5 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Jacob Garber (Code Review)
Martin Roth (Code Review)