Attention is currently required from: Shelley Chen, Hung-Te Lin, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56789 )
Change subject: libpayload/pci: Split PCI interfaces as common and chip related
......................................................................
Patch Set 12:
(2 comments)
File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/56789/comment/400bab8a_ed0c4008
PS12, Line 418:
Similar to coreboot's implementation, could we add ECAM_MMCONF_SUPPORT and ECAM_MMCONF_BASE_ADDRESS?
File payloads/libpayload/drivers/pci_map_bus_ops.c:
PS12:
Based on Shelly's design doc [1], should we call this pci_mmio_ops.c?
[1] https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/changes/61/57861...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie74801bd4f3de51cbb574e86cd9bb09931152554
Gerrit-Change-Number: 56789
Gerrit-PatchSet: 12
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 08 Mar 2022 02:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment